Lucas/20984 browser rendering screenshot fails #21031
Conversation
…call so puppeteer does not try to call fs to store images
coffee-mug
requested review from
a team,
celso,
danielgek and
mchenco
as code owners
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryFixed issue with screenshot functionality in Browser Rendering documentation for Cloudflare Workers.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add What is Hyperlint?Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation. |
workers-devprod
added
the
contribution
|
Congratulations @coffee-mug, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm8j4onr449380cl1mc5qlylk This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
* Fix - #20984 - removed path parameter from page.screenshot call so puppeteer does not try to call fs to store images * Fix: removed change to first sentence --------- Co-authored-by: Lucas Kostka <[email protected]>
8 participants
…ppeteer does not try to call fs to store images
Summary
closes #20984 for Browser Rendering documentation example.
The example shows how to take a screenshot with puppeteer from a worker and save the image in R2. In this example, the call to page.screenshot failed due to fs not being available in Cloudflare Workers.
Removing the "path" parameter from the call to page.screenshot fixed the issue, because puppeteer just passes the bytes array instead of trying to save the file locally.
Screenshots (optional)
Documentation checklist